a few orchestratord refactors in preparation for adding additional controllers #34337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doy-materialize
force-pushed
the
push-wtyxknkkzltv
branch
from
33e22aa to
e81e9c1
Compare
jubrad
reviewed
Dec 5, 2025
| #[clap(long)] | ||
| aws_account_id: Option<String>, | ||
| #[clap(long)] | ||
| environmentd_iam_role_arn: Option<String>, |
Contributor
There was a problem hiding this comment.
The refactor is fine, but it does remind me that we should we should be probalby have prefixed the flags with the cloud, iam_role_arn is pretty AWS specific, but being explicit that it's AWS would've been nice.
jubrad
approved these changes
Dec 5, 2025
Contributor
jubrad
left a comment
jubrad
left a comment
There was a problem hiding this comment.
Looks good. Very minor comments.
| ); | ||
| // the only way this can return an error is if we drop the writer, | ||
| // which we do not ever do, so unwrap is fine | ||
| store.wait_until_ready().await.unwrap(); |
Contributor
There was a problem hiding this comment.
Nit - probably viable to put use expect... expect("writer dropped")
|
|
||
| #[derive(Clone, Deserialize, Default)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct DefaultCertificateSpecs { |
Contributor
There was a problem hiding this comment.
should this be in orchestratord/src/tls.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
make it easier to split up some of our logic here into separate controllers
Tips for reviewer
this shouldn't result in any functional changes, only moving code around
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.